[webkit-reviews] review granted: [Bug 62097] regression(87771): ternary operator incorrectly identified as bitfield : [Attachment 96096] the patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Yong Li <yong.li.webkit at gmail.com>'s
request for review:
Bug 62097: regression(87771): ternary operator incorrectly identified as
bitfield
https://bugs.webkit.org/show_bug.cgi?id=62097

Attachment 96096: the patch
https://bugs.webkit.org/attachment.cgi?id=96096&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96096&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:2925
> +    matched =
re.match(r'\s*((const|mutable)\s+)?(char|(short(\s+int)?)|int|long(\s+(long|int
))?)\s+[a-zA-Z_][a-zA-Z0-9_]*\s*:\s*\d+\s*;', line)

seems you meant + not *, or?

Unfortunate that we don't have a nice constant for "identifier" since that long
regexp you added may be used in other places?