[webkit-reviews] review denied: [Bug 54562] Web Inspector: remove platform specifics from node highlight routines. : [Attachment 95477] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 54562: Web Inspector: remove platform specifics from node highlight
routines.
https://bugs.webkit.org/show_bug.cgi?id=54562

Attachment 95477: Patch
https://bugs.webkit.org/attachment.cgi?id=95477&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95477&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1474
> +    } else if (graphicsLayer == m_overlayLayer)
> +	  
m_renderView->frameView()->frame()->page()->pageOverlay()->paintComposited(cont
ext);

This is just too convoluted. RLC shouldn't have to know anything about
page()->pageOverlay().

I still think that the overlay layer should be hooked up outside of WebCore,
just like WK2 does it.