[webkit-reviews] review denied: [Bug 60563] [Chromium] Click event is not fired for a menulist <select> : [Attachment 95858] Add WEBKIT_IMPLEMENTATION change

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 60563: [Chromium] Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563

Attachment 95858: Add WEBKIT_IMPLEMENTATION change
https://bugs.webkit.org/attachment.cgi?id=95858&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95858&action=review

> Source/WebKit/chromium/tests/PopupMenuTest.cpp:33
> +#if WEBKIT_IMPLEMENTATION
> +#define WEBKIT_IMPLEMENTATION 0
> +#endif

Don't do this.

> Source/WebKit/chromium/tests/PopupMenuTest.cpp:38
> +#include <webkit/support/webkit_support.h>

Because webkit_support dependency is added, we can't build PopupMenuTest.cpp
with Chromium-win (shared) configuration.
You need to add PopupMenuTest.cpp to the sources! section of
https://trac.webkit.org/browser/trunk/Source/WebKit/chromium/WebKit.gyp?rev=879
48#L642