[webkit-reviews] review denied: [Bug 62118] Use of ENABLE(INSPECTOR) is inconsistent : [Attachment 96074] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 62118: Use of ENABLE(INSPECTOR) is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=62118

Attachment 96074: Patch
https://bugs.webkit.org/attachment.cgi?id=96074&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96074&action=review

> Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:301
> +#if ENABLE(INSPECTOR)

If ScriptProfiler call is guarded with ENABLE(INSPECTOR) here then
corresponding part of ScriptProfiler implementation should also be guarded, r-
for this.

Also, I'd rather keep all guards in ScriptProfiler.cpp