[webkit-reviews] review denied: [Bug 62099] createEvent("PopStateEvent") raises NOT_SUPPORTED_ERR: DOM Exception 9 : [Attachment 96053] Fixes based on feedback from previous review.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Paul Kinlan <paulkinlan at google.com>'s
request for review:
Bug 62099: createEvent("PopStateEvent") raises NOT_SUPPORTED_ERR: DOM Exception
9
https://bugs.webkit.org/show_bug.cgi?id=62099

Attachment 96053: Fixes based on feedback from previous review. 
https://bugs.webkit.org/attachment.cgi?id=96053&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96053&action=review

Otherwise it looks fine.  Lets go another round.

> ChangeLog:13
> +
> +	   * ../LayoutTests/fast/events/fire-popstate-event-expected.txt:
Added.
> +	   * ../LayoutTests/fast/events/fire-popstate-event.html: Added.
> +	   * ../Source/WebCore/dom/Document.cpp:
> +	   * ../Source/WebCore/dom/PopStateEvent.cpp:
> +	   * ../Source/WebCore/dom/PopStateEvent.h:

This ChangeLog should not be here. Please use the ones in /Source/WebCore and
/LayouTests

> Source/WebCore/dom/PopStateEvent.cpp:36
> +    , m_stateObject()

This line is not necessary, the construction is implicit.

> Source/WebCore/dom/PopStateEvent.h:41
> +    static PassRefPtr<PopStateEvent>
create(PassRefPtr<SerializedScriptValue> stateObject);

I don't think the parameter name adds much here.