[webkit-reviews] review denied: [Bug 48578] HTML5 Conformance Test failure: approved/canvas/canvas_text_font_001.htm : [Attachment 95743] Patch:Incorporating Eric's comment

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Mustafizur Rahaman
<mustaf.here at gmail.com>'s request for review:
Bug 48578: HTML5 Conformance Test failure:
approved/canvas/canvas_text_font_001.htm
https://bugs.webkit.org/show_bug.cgi?id=48578

Attachment 95743: Patch:Incorporating Eric's comment
https://bugs.webkit.org/attachment.cgi?id=95743&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You've used a dumpAsText test (which is good!), but I don't think you can
actually evaluate on the text output.  As-written, you have to actually look at
the pixels of your test to see if it worked.

I think instead you want to be checking what ctx.font returns after you set it
to "inherit" to make sure that the set was ignored.  Then you don't even need
to draw the strings.

If you look at fast/js/resources/js-test-pre.js (and the many many tests which
include this script) you can find a shouldBe function which can be helpful for
writing dumpAsText tests.  you can use shouldBe("ctx.font", "40px Times New
Roman") to make sure that the font doesn't change when you try to assign it
"inherit" etc.