[webkit-reviews] review denied: [Bug 62099] createEvent("PopStateEvent") raises NOT_SUPPORTED_ERR: DOM Exception 9 : [Attachment 96037] My proposed patch and test +ChangeLog Fix

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Paul Kinlan
<paulkinlan at google.com>'s request for review:
Bug 62099: createEvent("PopStateEvent") raises NOT_SUPPORTED_ERR: DOM Exception
9
https://bugs.webkit.org/show_bug.cgi?id=62099

Attachment 96037: My proposed patch and test +ChangeLog Fix
https://bugs.webkit.org/attachment.cgi?id=96037&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96037&action=review

Looks pretty good.

> Source/WebCore/dom/PopStateEvent.cpp:34
> +PopStateEvent::PopStateEvent()

You need to call Event's consturctor and initialize m_stateObject

> Source/WebCore/dom/PopStateEvent.h:40
> +    static PassRefPtr<PopStateEvent> create()

Would slightly prefer these factory methods being moved inside the .cpp

> Source/WebCore/dom/PopStateEvent.h:54
> +protected:

Does anythign sub-class this?  If not, put it inside "private:"