[webkit-reviews] review denied: [Bug 59005] Convert file <input> to use the new shadow DOM model : [Attachment 95952] Oh good lord I hate DOMUtilitiesPrivate.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 59005: Convert file <input> to use the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=59005

Attachment 95952: Oh good lord I hate DOMUtilitiesPrivate.
https://bugs.webkit.org/attachment.cgi?id=95952&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95952&action=review

I’m saying review- because I want the toXXX function to match our other toXXX
functions (the ones in WebCore, not in Chromium WebKit).

Otherwise this looks great

> Source/WebCore/css/html.css:525
> +input[type=file]::-webkit-file-upload-button {

Don’t you need quote marks around “file” as with the other rules in this file?

> Source/WebCore/html/HTMLInputElement.cpp:1846
> +HTMLInputElement* toHTMLInputElement(Node* node)
> +{
> +    return node && node->hasTagName(inputTag) ?
static_cast<HTMLInputElement*>(node) : 0;
> +}

These toXXX functions normally assert rather than returning 0. They are the
equivalent of static_cast, not of dynamic_cast.