[webkit-reviews] review granted: [Bug 62040] Support FontCustomPlatformData on Skia-Mac-Chrome variant : [Attachment 95959] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 3 14:30:19 PDT 2011


Eric Seidel <eric at webkit.org> has granted Cary Clark <caryclark at google.com>'s
request for review:
Bug 62040: Support FontCustomPlatformData on Skia-Mac-Chrome variant
https://bugs.webkit.org/show_bug.cgi?id=62040

Attachment 95959: Patch
https://bugs.webkit.org/attachment.cgi?id=95959&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95959&action=review

This approach seems reasonable.

> Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp:60
> +	       // This is request for the length of the stream.
> +	       return m_buffer->size();

What an awkward api!


More information about the webkit-reviews mailing list