[webkit-reviews] review denied: [Bug 60059] AssociatedURLLoader reports some errors synchronously : [Attachment 95934] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 3 11:55:03 PDT 2011


Adam Barth <abarth at webkit.org> has denied Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 60059: AssociatedURLLoader reports some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=60059

Attachment 95934: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=95934&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95934&action=review

This is starting to look good, but we're still lacking a test.

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:190
> +{

Please add the ASSERT I asked for in the previous review.


More information about the webkit-reviews mailing list