[webkit-reviews] review granted: [Bug 61538] [UNIX] SOCK_DGRAM sockets are not notified when the other end closes the connection : [Attachment 94986] Patch to use STREAM sockets

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 3 11:40:33 PDT 2011


Anders Carlsson <andersca at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 61538: [UNIX] SOCK_DGRAM sockets are not notified when the other end closes
the connection
https://bugs.webkit.org/show_bug.cgi?id=61538

Attachment 94986: Patch to use STREAM sockets
https://bugs.webkit.org/attachment.cgi?id=94986&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94986&action=review

> Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp:334
> +	   // Process messages from data received.
> +	   while (processMessage()) { }

I think this reads better as

while (true) {
    if (!processMessage())
      break;
}


More information about the webkit-reviews mailing list