[webkit-reviews] review granted: [Bug 61897] Flash of broken page when exiting full screen at jerryseinfeld.com : [Attachment 95930] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 61897: Flash of broken page when exiting full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61897

Attachment 95930: Patch
https://bugs.webkit.org/attachment.cgi?id=95930&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95930&action=review

> Source/WebCore/dom/Document.cpp:4788
> +    // Only create a placeholder block for a RenderBox, as only a box will
have a frameRect.

I'd like this comment to say what you say in the changelog about the fullscreen
element being taken out of normal flow. Otherwise the role of the placeholder
is unclear.

> Source/WebCore/rendering/RenderFullScreen.cpp:107
> +    m_placeholder->setFrameRect(frameRect);

Is this necessary? Won't layout happen and set the frame?