[webkit-reviews] review denied: [Bug 61915] [EFL][WK2] Add efl port's ewk_view files : [Attachment 95847] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 3 10:23:30 PDT 2011


Leandro Pereira <leandro at profusion.mobi> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 61915: [EFL][WK2] Add efl port's ewk_view files
https://bugs.webkit.org/show_bug.cgi?id=61915

Attachment 95847: Patch
https://bugs.webkit.org/attachment.cgi?id=95847&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=95847&action=review

I know nothing about WebKit2. I'm reviewing only style and other possibly minor
issues.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:286
> +    if (!sd->priv) {
> +	   EINA_LOG_CRIT("could not allocate _Ewk_View_Private_Data");
> +	   free(sd);
> +	   return;

Dangling reference. evas_object_smart_data_set(o, 0);

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:320
> +    EWK_VIEW_SD_GET(o, sd);

EWK_VIEW_SD_GET_OR_RETURN(...)

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:332
> +    EWK_VIEW_SD_GET(o, sd);

Ditto. Please review all EWK_VIEW_SD_GET() usage on the following functions.


More information about the webkit-reviews mailing list