[webkit-reviews] review denied: [Bug 61993] [EFL][WK2] add WebKit2 EFL port's NativeWebMouseEvent and NativeWebWheelEvent : [Attachment 95856] Patch

[bugzilla-daemon at webkit.org]

Leandro Pereira <leandro at profusion.mobi> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 61993: [EFL][WK2] add WebKit2 EFL port's NativeWebMouseEvent and
NativeWebWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=61993

Attachment 95856: Patch
https://bugs.webkit.org/attachment.cgi?id=95856&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=95856&action=review

I know nothing about WebKit2, but I can comment about some style issues.

> Source/WebKit2/Shared/efl/NativeWebMouseEventEfl.cpp:37
> +NativeWebMouseEvent::NativeWebMouseEvent(const Evas_Event_Mouse_Down* event,
const Evas_Point* position)
> +    : WebMouseEvent(WebEventFactory::createWebMouseEvent(event, position))
> +    , m_nativeEvent(event)
> +{
> +}

notImplemented();

> Source/WebKit2/Shared/efl/NativeWebMouseEventEfl.cpp:43
> +NativeWebMouseEvent::NativeWebMouseEvent(const Evas_Event_Mouse_Up* event,
const Evas_Point* position)
> +    : WebMouseEvent(WebEventFactory::createWebMouseEvent(event, position))
> +    , m_nativeEvent(event)
> +{
> +}

notImplemented();

> Source/WebKit2/Shared/efl/NativeWebMouseEventEfl.cpp:49
> +NativeWebMouseEvent::NativeWebMouseEvent(const Evas_Event_Mouse_Move* event,
const Evas_Point* position)
> +    : WebMouseEvent(WebEventFactory::createWebMouseEvent(event, position))
> +    , m_nativeEvent(event)
> +{
> +}

notImplemented();

> Source/WebKit2/Shared/efl/NativeWebWheelEventEfl.cpp:37
> +NativeWebWheelEvent::NativeWebWheelEvent(const Evas_Event_Mouse_Wheel*
event, const Evas_Point* position)
> +    : WebWheelEvent(WebEventFactory::createWebWheelEvent(event, position))
> +    , m_nativeEvent(event)
> +{
> +}

notImplemented();

> Source/WebKit2/Shared/efl/WebEventFactory.cpp:52
> +    return (WebEvent::Modifiers)result;

Use C++-style cast.

> Source/WebKit2/Shared/efl/WebEventFactory.h:43
> +

Whereis the #endif?