[webkit-reviews] review denied: [Bug 61999] [EFL][WK2] Add an option to build WebKit2. : [Attachment 95870] Patch

[bugzilla-daemon at webkit.org]

Leandro Pereira <leandro at profusion.mobi> has denied Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 61999: [EFL][WK2] Add an option to build WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=61999

Attachment 95870: Patch
https://bugs.webkit.org/attachment.cgi?id=95870&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=95870&action=review

> Source/CMakeLists.txt:125
>  ADD_SUBDIRECTORY(WebKit)
> +IF (ENABLE_WEBKIT2)
> +    ADD_SUBDIRECTORY(WebKit2)
> +ENDIF ()

WebKit always be built if one only wants WebKit2. Is this the expected
behaviour?

> Source/CMakeLists.txt:133
> +IF (ENABLE_WEBKIT2)
> +   
INCLUDE_IF_EXISTS(${TOOLS_DIR}/MiniBrowser/${WEBKIT_PORT_DIR}/CMakeLists${PORT}
.txt)
> +ENDIF ()

I'd change Tools/CMakeListsEfl.txt instead.