[webkit-reviews] review granted: [Bug 34301] Creating <animateMotion> elements via javascript do not execute : [Attachment 95808] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 34301: Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=34301

Attachment 95808: Patch
https://bugs.webkit.org/attachment.cgi?id=95808&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95808&action=review

This is fine as-is, though some comments:

> Source/WebCore/page/DOMWindow.idl:719
> -//	   attribute SVGAnimateMotionElementConstructor
SVGAnimateMotionElement;
> +	 attribute SVGAnimateMotionElementConstructor SVGAnimateMotionElement;

The alignment doesn't match here.

> Source/WebCore/page/DOMWindow.idl:721
> +	 attribute SVGMPathElementConstructor SVGMPathElement;

Ditto.

> LayoutTests/svg/custom/global-constructors-expected.txt:143
>  FAIL SVGAnimationElement.toString() should be [object
SVGAnimationElementConstructor]. Threw exception ReferenceError: Can't find
variable: SVGAnimationElement

Just noticed this, seems we have another constructor missing? Can you grep that
file for other missing SVG constructors?