[webkit-reviews] review denied: [Bug 61857] Value of a range input does not update visually when using setAttribute : [Attachment 95719] hasDirtyValue, better test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 17:52:15 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 61857: Value of a range input does not update visually when using
setAttribute
https://bugs.webkit.org/show_bug.cgi?id=61857

Attachment 95719: hasDirtyValue, better test
https://bugs.webkit.org/attachment.cgi?id=95719&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't understand why you are saying this. We should not rename data members
in our heads, they should have good names!

>From your description, it appears that m_value might need to be renamed to
m_valueIfDirty. Let's explore that before landing this patch, because in the
current state, it makes the code strictly worse. Marking r- to that effect.


More information about the webkit-reviews mailing list