[webkit-reviews] review granted: [Bug 61979] Prevent event dispatch for events with related target when host is the target. : [Attachment 95831] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 17:47:40 PDT 2011


Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 61979: Prevent event dispatch for events with related target when host is
the target.
https://bugs.webkit.org/show_bug.cgi?id=61979

Attachment 95831: Patch
https://bugs.webkit.org/attachment.cgi?id=95831&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95831&action=review

> Source/WebCore/dom/EventDispatcher.h:73
> +    bool m_preventDispatch;

Normally it’s best to avoid using a verb phrase for a data member, even a
boolean one. Perhaps m_shouldPreventDispatch.


More information about the webkit-reviews mailing list