[webkit-reviews] review denied: [Bug 61963] bindings/v8/DOMData.h/.cpp has numerous errors in processing DOMDataStores for different threads : [Attachment 95815] Style fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 16:23:04 PDT 2011


David Levin <levin at chromium.org> has denied  review:
Bug 61963: bindings/v8/DOMData.h/.cpp has numerous errors in processing
DOMDataStores for different threads
https://bugs.webkit.org/show_bug.cgi?id=61963

Attachment 95815: Style fixes
https://bugs.webkit.org/attachment.cgi?id=95815&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95815&action=review

> Source/WebCore/bindings/v8/DOMData.h:88
> +	       if (store->domData()->owningThread() != WTF::currentThread())

Actually I take back my r+. Why is this change correct?

How does this function get called on the wrong thread?	And if it get called on
the wrong thread, won't there be problems since removeIfPresent wasn't called?


More information about the webkit-reviews mailing list