[webkit-reviews] review granted: [Bug 61690] [GTK] Remove PastboardHelperGtk : [Attachment 95272] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 16:15:38 PDT 2011


Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 61690: [GTK] Remove PastboardHelperGtk
https://bugs.webkit.org/show_bug.cgi?id=61690

Attachment 95272: Patch
https://bugs.webkit.org/attachment.cgi?id=95272&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95272&action=review

yay; need to go through this simplification drill on the fullscreen video stuff
sometime

> Source/WebCore/ChangeLog:5
> +	   [GTK] Remove PastboardHelperGtk

missing e on Paste

> Source/WebCore/ChangeLog:15
> +	   * platform/Pasteboard.h: Remove GTK+ specific methods. They are no
longer needed.j

trailing j

> Source/WebCore/platform/gtk/PasteboardGtk.cpp:59
> +    PasteboardHelper* defaultHelper =
PasteboardHelper::defaultPasteboardHelper();

just a suggestion, I'd use helper here instead of defaultHelper for the
variable name; 'default' doesn't really add much information


More information about the webkit-reviews mailing list