[webkit-reviews] review granted: [Bug 61953] cleanup DrawingBufferChromium, correct comment : [Attachment 95804] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 14:15:35 PDT 2011


James Robinson <jamesr at chromium.org> has granted John Bates
<jbates at google.com>'s request for review:
Bug 61953: cleanup DrawingBufferChromium, correct comment
https://bugs.webkit.org/show_bug.cgi?id=61953

Attachment 95804: Patch
https://bugs.webkit.org/attachment.cgi?id=95804&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95804&action=review

> Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp:83
> +    , m_platformLayer(0)

You don't need to 0-initialize RefPtr<>s, and in fact this'll stop compiling
when we get stricter about RefPtr/PassRefPtr usage.  Just leave the
initialization out - the default c'tor for RefPtr does the right thing.


More information about the webkit-reviews mailing list