[webkit-reviews] review denied: [Bug 61953] cleanup DrawingBufferChromium, correct comment : [Attachment 95794] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied John Bates
<jbates at google.com>'s request for review:
Bug 61953: cleanup DrawingBufferChromium, correct comment
https://bugs.webkit.org/show_bug.cgi?id=61953

Attachment 95794: Patch
https://bugs.webkit.org/attachment.cgi?id=95794&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95794&action=review

Patch looks great, but R- for the odd forward declaration and lack of verbosity
in the ChangeLog.  Thanks a bunch for cleaning this up.

> Source/WebCore/ChangeLog:8
> +	   https://bugs.webkit.org/show_bug.cgi?id=61953
> +
> +	   * platform/graphics/chromium/DrawingBufferChromium.cpp:

please put a more verbose description here if what this patch does.

> Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp:46
> +class Canvas2DLayerChromium { };

To forward declare Canvas2DLayerChromium just do:

class Canvas2DLayerChromium;

I don't think you need to do this, however - do you?  I think all the
references to Canvas2DLayerChromium are guarded by #if
USE(ACCELERATED_COMPOSITING), or at least they should be.