[webkit-reviews] review granted: [Bug 61948] Add quirk for plug-ins that return a retained CALayer : [Attachment 95783] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 61948: Add quirk for plug-ins that return a retained CALayer
https://bugs.webkit.org/show_bug.cgi?id=61948

Attachment 95783: Patch
https://bugs.webkit.org/attachment.cgi?id=95783&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95783&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:418
>  static const unsigned WKNVSupportsCompositingCoreAnimationPluginsBool =
74656;
>  
>  // The Core Animation render server port.
>  static const unsigned WKNVCALayerRenderServerPort = 71879;
>  
> +// Whether the browser expects a non-retained Core Animation layer.
> +static const unsigned WKNVExpectsNonretainedLayer = 0x574b0000;

Seems odd to have a random-seeming int for
WKNVSupportsCompositingCoreAnimationPluginsBool, and a large hex value for
WKNVExpectsNonretainedLayer