[webkit-reviews] review denied: [Bug 60059] AssociatedURLLoader reports some errors synchronously : [Attachment 92131] Proposed Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 60059: AssociatedURLLoader reports some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=60059

Attachment 92131: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=92131&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92131&action=review

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:185
> +	   m_errorTimer = new Timer<ClientAdapter>(this,
&ClientAdapter::notifyError);

WebKit frowns upon "naked new", meaning calls to new should immediately be
followed by either adoptPtr or adoptRef, as appropriate.  In any case, we just
normally make these Timer objects be regular members, not pointers.  Actually,
I'm surprised this patch even compiles.  There must be something wrong
somwhere.