[webkit-reviews] review granted: [Bug 60328] NRWT needs a way to log to a file without including backspaces without needing --verbose : [Attachment 95689] fix changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 10:09:44 PDT 2011


Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 60328: NRWT needs a way to log to a file without including backspaces
without needing --verbose
https://bugs.webkit.org/show_bug.cgi?id=60328

Attachment 95689: fix changelog
https://bugs.webkit.org/attachment.cgi?id=95689&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95689&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py:47
> +FAST_UPDATES = 0.03
> +SLOW_UPDATES = 10.0

Can we add units to these variables?  FAS_UPDATES_SECONDS, etc

> Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py:221
> +	       self._update_interval = FAST_UPDATES

_update_interval -> _update_interval_seconds


More information about the webkit-reviews mailing list