[webkit-reviews] review granted: [Bug 61909] REGRESSION(r87014): Cloned text <input> doesn't work well : [Attachment 95747] Patch 5

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 61909: REGRESSION(r87014): Cloned text <input> doesn't work well
https://bugs.webkit.org/show_bug.cgi?id=61909

Attachment 95747: Patch 5
https://bugs.webkit.org/attachment.cgi?id=95747&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I think the getElementById logic is pretty cool. I am excited to see this being
used.

To patch this hole, I am fine with loading this patch.

However, I think the solution is incomplete and we shouldn't fix it just for
text inputs. The core issue is in the fact that _all_ elements with shadow DOM
will lose their marbles and will require manual fixes like this. This is
something we should anticipate. I believe the right fix is in generalizing
createShadowSubtree and calling it during cloning. Or perhaps creating an
"unitialized" state for shadow DOM, where createShadowSubtree is called when
shadowRoot is first accessed in the clone.