[webkit-reviews] review granted: [Bug 59737] Focus and caret position should be updated when same-page links are followed : [Attachment 92239] Patch proposal + Layout test

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 59737: Focus and caret position should be updated when same-page links are
followed
https://bugs.webkit.org/show_bug.cgi?id=59737

Attachment 92239: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=92239&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92239&action=review

Okay! Seems sane.

> Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:228
> +    Position targetPosition =
firstPositionInOrBeforeNode(const_cast<Node*>(node));
> +    selection->moveTo(targetPosition, DOWNSTREAM);

This seems simple enough to make into one line. Please change before landing.