[webkit-reviews] review granted: [Bug 55603] [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange) : [Attachment 92100] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 55603: [GTK] Implement the next bit of the TextInputController
(hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603

Attachment 92100: Patch
https://bugs.webkit.org/attachment.cgi?id=92100&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92100&action=review

I'm willing to rubber stamp this if that's what you're looking for.  If you
need a more detailed review from a gtk person, you should set r? again.

> LayoutTests/platform/gtk/Skipped:666
> +# These tests also use firstRectForCharacterRange, but they generate
slightly
> +# different values. (Chromium also fails here; see their
test_expectations.txt file)

Do we match chromium?

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:539
> +    *start = *length = 0;

Um.  Why not pass these by reference?