[webkit-reviews] review denied: [Bug 61865] [Qt] Implement download feature for QtTestBrowser : [Attachment 95752] proposed patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied tbarat
<Barat.Tibor at stud.u-szeged.hu>'s request for review:
Bug 61865: [Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865

Attachment 95752: proposed patch
https://bugs.webkit.org/attachment.cgi?id=95752&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95752&action=review

> Tools/QtTestBrowser/launcherwindow.cpp:53
>      , m_zoomAnimation(0)
> +    , m_reply(0)
>  {

Please update this part of the patch, because it conflicts with ToT.

> Tools/QtTestBrowser/launcherwindow.cpp:940
> +    connect(m_reply, SIGNAL(finished()), this, SLOT(slotFinished()));

I can't find slotFinished anywhere, but fileDownloadFinished.

> Tools/QtTestBrowser/launcherwindow.cpp:950
> +    if (fileName.isEmpty() || !m_reply->errorString().isNull())
> +	   QMessageBox::warning(this, QString("Download"), QString("Download
failed."));

It fails for me, m_reply->errorString() returns always with "Unknown error."