[webkit-reviews] review denied: [Bug 61894] DocumentLoader keeps a reference to all URL strings ever loaded in m_resourcesClientKnowsAbout leading to lots of memory waste : [Attachment 95708] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied  review:
Bug 61894: DocumentLoader keeps a reference to all URL strings ever loaded in
m_resourcesClientKnowsAbout leading to lots of memory waste
https://bugs.webkit.org/show_bug.cgi?id=61894

Attachment 95708: Patch
https://bugs.webkit.org/attachment.cgi?id=95708&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Especially since we don't even need it in WK2, we should be able to get away
from this in WK1 too.

But clearly we can't simply remove this concept until someone explores the Mac
port's usage of it.

I'd suggest a better patch for now that would be a greater win for WebCore and
all ports as a whole, in readability and prepping for future removal of this
code:
- File bugzilla for the Mac port exploration as Eric suggested
- In DocumentLoader.h, put didTellClientAboutLoad, haveToldClientAboutLoad, and
m_resourcesClientKnowsAbout in a single #if PLATFORM(MAC) block.  Note that
this means for non-Mac platforms, they will be compiled out and not exist.
- Put an #if PLATFORM(MAC) block at the call sites of the two methods.	Without
looking at code, I bet this will only be a few places. (you probably already
know)
- Take these 3 or 4 #if PLATFORM(MAC) sites with a FIXME that includes the
bugzilla you filed.