[webkit-reviews] review denied: [Bug 37743] Separate clock time functions used by JavaScript from monotonically increasing time needed elsewhere : [Attachment 95706] Patch based on Leo's
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 1 19:59:31 PDT 2011
James Robinson <jamesr at chromium.org> has denied Jason
<liuyang12341982 at 163.com>'s request for review:
Bug 37743: Separate clock time functions used by JavaScript from monotonically
increasing time needed elsewhere
https://bugs.webkit.org/show_bug.cgi?id=37743
Attachment 95706: Patch based on Leo's
https://bugs.webkit.org/attachment.cgi?id=95706&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95706&action=review
I don't think you can change the semantics of javascript Date.now()!
Have you followed the recent discussion on this bug?
> Source/JavaScriptCore/wtf/CurrentTime.cpp:317
> +// Added currentUTCTime which should be used by JScurrentTime(). And changed
currentTime() with
> +// monotonically Increasing codes.
woah, you can't do this!
More information about the webkit-reviews
mailing list