[webkit-reviews] review denied: [Bug 61674] <input> checkbox and radio attribute value default value incorrect : [Attachment 95578] Incorporating review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 18:50:14 PDT 2011


Kent Tamura <tkent at chromium.org> has denied Naiem <naiem.shaik at gmail.com>'s
request for review:
Bug 61674: <input> checkbox and radio attribute value default value incorrect
https://bugs.webkit.org/show_bug.cgi?id=61674

Attachment 95578: Incorporating review comments
https://bugs.webkit.org/attachment.cgi?id=95578&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95578&action=review

> Source/WebCore/ChangeLog:17
> +	   Reviewed by NOBODY (OOPS!).
> +	   As per http://www.w3.org/TR/html5/number-state.html#checkbox-state
and
> +	   http://www.w3.org/TR/html5/number-state.html#radio-button-state:
> +	   The value IDL attribute is in mode default/on: 
> +	   If the element has a value attribute, it must return that
attribute's 
> +	   value; otherwise, it must return the string "on".  
> +	   Currently default value is empty string;Default value of Radio
button 
> +	   and checkbox should be "on"
> +	   This works as per spec in IE9,Firefox and Opera
> +	   https://bugs.webkit.org/show_bug.cgi?id=61674
> +
> +	   Tests: fast/forms/checkbox-default-value.html
> +		  fast/forms/radio-default-value.html
> +
> +	   * html/BaseCheckableInputType.cpp:

The standard format of ChangeLog entry is:

  Reviewed by NOBODY (OOPS!).

  <One-line summary of the change>
  <Bug URL>

  <Detail of the change>

  Tests: ...

  * <Updated file list>

> LayoutTests/fast/forms/checkbox-default-value.html:9
> +    shouldBe('el.value', '"on"');

Let's test more cases.

shouldBe('el.setAttribute("value", "foo"); el.value', '"foo"');
shouldBe('el.checked = true; el.value', '"foo"');
shouldBe('el.removeAttribute("value"); el.value', '"on"');
shouldBe('el.value = "foo"; el.getAttribute("value")', '"foo"');


More information about the webkit-reviews mailing list