[webkit-reviews] review granted: [Bug 61886] Safari always crashes on http://bbc.co.uk when VoiceOver enabled : [Attachment 95671] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 15:34:03 PDT 2011


Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 61886: Safari always crashes on http://bbc.co.uk when VoiceOver enabled
https://bugs.webkit.org/show_bug.cgi?id=61886

Attachment 95671: patch
https://bugs.webkit.org/attachment.cgi?id=95671&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95671&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:725
> +    Document* doc = document();
> +    if (doc)
> +	   doc->updateLayoutIgnorePendingStylesheets();

The best style for this is:

    if (Document* document = this->document())
	document->updateLayoutIgnorePendingStylesheets();


More information about the webkit-reviews mailing list