[webkit-reviews] review denied: [Bug 61884] Switch paintOverflowControls to use IntPoint : [Attachment 95666] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 61884: Switch paintOverflowControls to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61884

Attachment 95666: Patch
https://bugs.webkit.org/attachment.cgi?id=95666&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95666&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2284
> +	   m_cachedOverlayScrollbarOffset = paintOffset;

eeewww.  Wonder why this exists.

> Source/WebCore/rendering/RenderLayer.cpp:2295
> +	   adjustedPaintOffset.move(m_cachedOverlayScrollbarOffset);

This doesn't look right.  I think you meant =.

> Source/WebCore/rendering/RenderLayerBacking.cpp:1105
> +    int tx = layerBounds.x() - m_owningLayer->renderBoxX();
> +    int ty = layerBounds.y() - m_owningLayer->renderBoxY();

I guess we're not ready to kill the tx, ty here yet? :)