[webkit-reviews] review granted: [Bug 61721] Test plugin should support event logging on the windows port. : [Attachment 95600] Patch for review.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 14:21:13 PDT 2011


Tony Chang <tony at chromium.org> has granted noel gordon
<noel.gordon at gmail.com>'s request for review:
Bug 61721: Test plugin should support event logging on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=61721

Attachment 95600: Patch for review.
https://bugs.webkit.org/attachment.cgi?id=95600&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
This looks correct to me.

Events generated by eventSender probably won't get forwarded to windowed
plugins since windowed plugins get events from the OS (I guess we could try to
make OS events and forward them, but that's probably not worth the effort).  By
making it a windowless plugin, WebKit can forward the events to the plugin.


More information about the webkit-reviews mailing list