[webkit-reviews] review denied: [Bug 7169] Support exporting of MHTML web archives : [Attachment 95633] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Jay Civelli <jcivelli at chromium.org>'s
request for review:
Bug 7169: Support exporting of MHTML web archives
https://bugs.webkit.org/show_bug.cgi?id=7169

Attachment 95633: Patch
https://bugs.webkit.org/attachment.cgi?id=95633&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95633&action=review

> Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp:144
> +#if OS(WINDOWS)
> +    __time64_t time;
> +    _time64(&time); 
> +    if (_localtime64_s(&timeAndDate, &time))
> +	   ASSERT_NOT_REACHED();
> +#else
> +    timeval timeValue = { 0 };
> +    if (gettimeofday(&timeValue, 0) || !localtime_r(&(timeValue.tv_sec),
&timeAndDate))
> +	   ASSERT_NOT_REACHED();
> +#endif

We shouldn't have platform-specific code in this file.	Maybe move this stuff
to WTF?  Are you sure there isn't already a way to do this in WTF?