[webkit-reviews] review granted: [Bug 18228] SVG graphics do not actually work in IMG tags or as background-image properties : [Attachment 95637] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 18228: SVG graphics do not actually work in IMG tags or as background-image
properties
https://bugs.webkit.org/show_bug.cgi?id=18228

Attachment 95637: Patch
https://bugs.webkit.org/attachment.cgi?id=95637&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95637&action=review

LGTM

> LayoutTests/svg/custom/resources/spinner.svg:4
> +<svg xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink" width="40px" height="40px"
viewBox="0 0 50 50" preserveAspectRatio="xMinYMin">

preserveAspectRatio needed? And not the default value used?

> LayoutTests/svg/custom/resources/spinner.svg:10
> +	   <animateTransform attributeName="transform" type="rotate"
values="30,25,25; 60,25,25; 90,25,25; 120,25,25; 150,25,25; 180,25,25;
210,25,25; 240,25,25; 270,25,25; 300,25,25; 330,25,25; 0,25,25;" dur="1s"
repeatCount="indefinite" calcMode="discrete" />

Line can be removed