[webkit-reviews] review granted: [Bug 61818] Switch RenderLayer::convertToLayerCoords to use IntPoint : [Attachment 95640] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 61818: Switch RenderLayer::convertToLayerCoords to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61818

Attachment 95640: Patch
https://bugs.webkit.org/attachment.cgi?id=95640&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95640&action=review

LGTM.  I think you should consider doing convertToLayerCoords(rect) in this
patch or the next, as allt hese callsites will suddenly become simpler. :)

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1089
> +		   curLayer->convertToLayerCoords(layer, delta);
>		   IntRect childRect(rect);
> -		   childRect.move(-x, -y);
> +		   childRect.move(-delta.x(), -delta.y());

I suspect we just need a rect version of convertToLayerCoords eventually. :) 
Actually, given all the places you did the same dance in this patch, it might
make sense to just add convertToLayerCoords(layer, rect) which does exactly
this. :)