[webkit-reviews] review granted: [Bug 61788] [GTK] Utility methods for UA spellchecking : [Attachment 95619] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 61788: [GTK] Utility methods for UA spellchecking
https://bugs.webkit.org/show_bug.cgi?id=61788

Attachment 95619: Patch
https://bugs.webkit.org/attachment.cgi?id=95619&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95619&action=review

Great!

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:1009
> + * Returns: a #WebKitDOMRange spanning the word, if any, where the
> + * caret currently is positioned

Should probably say something like: a #WebKitDOMRange spanning the word where
the caret is currently positioned. If there is no caret this method returns
null.

Explicitly mentioning null here is a tipoff to embedders that they need to
handle that.