[webkit-reviews] review granted: [Bug 61819] nrwt: make webaudio work w/o content-length header : [Attachment 95517] restore newlines in DRT output

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 61819: nrwt: make webaudio work w/o content-length header
https://bugs.webkit.org/show_bug.cgi?id=61819

Attachment 95517: restore newlines in DRT output
https://bugs.webkit.org/attachment.cgi?id=95517&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95517&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py:319
> +	   self._print_baseline(filename, '.txt')
> +	   self._print_baseline(filename, '.wav')
> +	   self._print_baseline(filename, '.png')

Nit: Maybe make this a for loop (one less line of code)?

> Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:150
> +	   if driver_output.text:
> +	       self._save_baseline_data(driver_output.text, ".txt",

Nit: Should we just have _safe_baseline_data bail out if the first param is
None?