[webkit-reviews] review granted: [Bug 61845] Remove outer-spin-button : [Attachment 95562] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 1 09:34:01 PDT 2011
Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 61845: Remove outer-spin-button
https://bugs.webkit.org/show_bug.cgi?id=61845
Attachment 95562: Patch
https://bugs.webkit.org/attachment.cgi?id=95562&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95562&action=review
I think simpler is better, so I like this change.
> LayoutTests/ChangeLog:13
> + * platform/mac/fast/forms/input-appearance-spinbutton-expected.png:
The spin button looks a bit too close to the top.
> Source/WebCore/ChangeLog:8
> + Remove outer-spin-button, and render steppers as inner-spin-button.
I think you need to put a bit more explanation as to why here in the log.
More information about the webkit-reviews
mailing list