[webkit-reviews] review requested: [Bug 48290] Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html : [Attachment 95588] Fix after build break reported in Chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 05:48:29 PDT 2011


sarapkarthik <sarap.karthik at gmail.com> has asked  for review:
Bug 48290: Fix
LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
https://bugs.webkit.org/show_bug.cgi?id=48290

Attachment 95588: Fix after build break reported in Chromium
https://bugs.webkit.org/attachment.cgi?id=95588&action=review

------- Additional Comments from sarapkarthik <sarap.karthik at gmail.com>
I have made an alternate/simpler fix after my previous fix broke the Chromium
build. In stead of removing "highlight"/CompositeHighlight we are just checking
for "highlight" in CanvasRenderingContext2D::setGlobalCompositeOperation() &
returning false so that it does not go to parseCompositeOperator()


More information about the webkit-reviews mailing list