[webkit-reviews] review requested: [Bug 48578] HTML5 Conformance Test failure: approved/canvas/canvas_text_font_001.htm : [Attachment 95573] Alternate solution proposed after Adam Barth's comment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 03:03:07 PDT 2011


Mustafizur Rahaman <mustaf.here at gmail.com> has asked  for review:
Bug 48578: HTML5 Conformance Test failure:
approved/canvas/canvas_text_font_001.htm
https://bugs.webkit.org/show_bug.cgi?id=48578

Attachment 95573: Alternate solution proposed after Adam Barth's comment
https://bugs.webkit.org/attachment.cgi?id=95573&action=review

------- Additional Comments from Mustafizur Rahaman <mustaf.here at gmail.com>
As Adam mentioned that it is not a good idea to fix this in CSS Parser, so I
tried to modify CanvasRenderingContext2D::setFont() so that if the new font
contains"inherit" it should not allow assigning the new font value.


More information about the webkit-reviews mailing list