[webkit-reviews] review canceled: [Bug 61841] WebSocket: Call WebSocketChannel::fail() when WebSocketHandshake has failed : [Attachment 95561] Patch

[bugzilla-daemon at webkit.org]

Yuta Kitamura <yutak at chromium.org> has canceled Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 61841: WebSocket: Call WebSocketChannel::fail() when WebSocketHandshake has
failed
https://bugs.webkit.org/show_bug.cgi?id=61841

Attachment 95561: Patch
https://bugs.webkit.org/attachment.cgi?id=95561&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95561&action=review

>> Source/WebCore/websockets/WebSocketChannel.cpp:337
>> +	    fail(m_handshake.failureReason());
> 
> This looks a behavior change.
> fail() calls m_handle->close(), not m_handle->disconnect(), right?

Good point.

This sounds like a bug of fail(), rather than of this patch. I should have used
m_handle->disconnect() in fail(), because we don't have to wait for unsent data
to be sent (difference between m_handle->close() and m_handle->disconnect() is
that the former does not close the connection until the socket finishes to send
all data while the latter immediately closes the connection).

I will create a new bug and fix this.