[webkit-reviews] review granted: [Bug 61825] Change the Page Visibility attribute names as per the spec : [Attachment 95521] Patch

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted Shishir Agrawal
<shishir at chromium.org>'s request for review:
Bug 61825: Change the Page Visibility attribute names as per the spec
https://bugs.webkit.org/show_bug.cgi?id=61825

Attachment 95521: Patch
https://bugs.webkit.org/attachment.cgi?id=95521&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95521&action=review

Please update the ChangeLog, everything else looks good.

> Source/WebCore/ChangeLog:6
> +	   https://bugs.webkit.org/show_bug.cgi?id=61825

In the bug, you mention:
1. The event needs to be webkitVisibilityChange from
webkitVisibilityStateChange
2. The attribute webkitIsVisible needs to change to webkitHidden

That sort of description should always go in the ChangeLog. Also, if available,
a link to the spec update would be nice.