[webkit-reviews] review granted: [Bug 61839] Refactor functions related with focus in WebCore::Document : [Attachment 95558] move focus related functions from Document to FocusController

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 61839: Refactor functions related with focus in WebCore::Document
https://bugs.webkit.org/show_bug.cgi?id=61839

Attachment 95558: move focus related functions from Document to FocusController
https://bugs.webkit.org/attachment.cgi?id=95558&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95558&action=review

> Source/WebCore/page/FocusController.cpp:312
> +    for (Node* n = start; n; n = n->traverseNextNode())

nit: Should avoid 1-letter variable name.

> Source/WebCore/page/FocusController.cpp:332
> +    int winningTabIndex = SHRT_MAX + 1;

nit: Because this is C++, we had better use numeric_limits<short> instead of
SHRT_MAX.

> Source/WebCore/page/FocusController.h:79
> +    /**

nit: We usually use '//' for comments.