[webkit-reviews] review granted: [Bug 65413] Introduce SpecifierSorter, a thing that knows how specifiers should be ordered. : [Attachment 102440] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 65413: Introduce SpecifierSorter, a thing that knows how specifiers should
be ordered.
https://bugs.webkit.org/show_bug.cgi?id=65413

Attachment 102440: Patch
https://bugs.webkit.org/attachment.cgi?id=102440&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102440&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:84
> +    def add_specifier(self, category, specifier):
> +	   self._specifier_to_category[specifier] = category

Should this be private?

> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:99
> +	   category_slots = []
> +	   for i in range(len(TestConfiguration.category_order())):
> +	       category_slots.append([])

category_slots = [[]] * len(TestConfiguration.category_order())

or

category_slots = map(lambda x: [], TestConfiguration.category_order())