[webkit-reviews] review granted: [Bug 65324] REGRESSION: getBoundingClientRect() method of Range incorrectly returns null for collapsed Range : [Attachment 102465] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 65324: REGRESSION: getBoundingClientRect() method of Range incorrectly
returns null for collapsed Range
https://bugs.webkit.org/show_bug.cgi?id=65324

Attachment 102465: Patch
https://bugs.webkit.org/attachment.cgi?id=102465&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102465&action=review


The change makes sense to me.

> LayoutTests/fast/dom/Range/getBoundingClientRect.html:114
> +	   /*4*/  { left: 0, top: 0, width: 0, height: 0 },
> +	   /*5*/  { left: -14.574, top: 1761.947, width: 504.009, height:
535.849 },
> +	   /*6*/  { left: 0, top: 0, width: 0, height: 0 },

It's not great that this test depends on particular font metrics and is failing
on non-Mac ports :(  Can we instead wrap each text with a span and compare
span's offset* and bounding rect?