[webkit-reviews] review denied: [Bug 65420] WebKit2 crashes on attempt to decode null image : [Attachment 102455] Fix crash on attempt to decode null image v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 30 23:09:51 PDT 2011


Darin Adler <darin at apple.com> has denied Oleg Romashin (:romaxa)
<romaxa at gmail.com>'s request for review:
Bug 65420: WebKit2 crashes on attempt to decode null image
https://bugs.webkit.org/show_bug.cgi?id=65420

Attachment 102455: Fix crash on attempt to decode null image v2
https://bugs.webkit.org/attachment.cgi?id=102455&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is wrong for the same reason the other one is. Encoding no bytes at all
does not work on the decoding side. The decodeImage function has no way to know
that the image was null, and so will attempt to decode the image, and thus the
decoding process will be off.


More information about the webkit-reviews mailing list