[webkit-reviews] review denied: [Bug 65422] Simplify JSFunction creation for functions written in JS : [Attachment 102447] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied  review:
Bug 65422: Simplify JSFunction creation for functions written in JS
https://bugs.webkit.org/show_bug.cgi?id=65422

Attachment 102447: Patch
https://bugs.webkit.org/attachment.cgi?id=102447&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r- because i just copied the old logic (which did an empty string check) and i
don't want to just blindly commit.

That said, we do have to do the setting of m_jsName late as jsString() may
perform a gc allocation, and it is _never_ safe to do GC allocation in the
initializer list (you may end up doing a gc sweep midway through executing your
initializer list, and then you end up not marking yourself correctly :-( )